Skip to content

GH-36349: [Python][CI] Avoid using 'build/etc/localtime' timezone in hypothesis tests#36391

Merged
raulcd merged 1 commit into
apache:mainfrom
jorisvandenbossche:gh-36349-hypothesis-localtime
Jun 30, 2023
Merged

GH-36349: [Python][CI] Avoid using 'build/etc/localtime' timezone in hypothesis tests#36391
raulcd merged 1 commit into
apache:mainfrom
jorisvandenbossche:gh-36349-hypothesis-localtime

Conversation

@jorisvandenbossche

@jorisvandenbossche jorisvandenbossche commented Jun 29, 2023

Copy link
Copy Markdown
Member

What changes are included in this PR?

Skip the test if the timezone is zoneinfo.ZoneInfo(key='build/etc/localtime'), because we don't support roundtripping such a timezone

@github-actions

Copy link
Copy Markdown

⚠️ GitHub issue #36349 has been automatically assigned in GitHub to PR creator.

@jorisvandenbossche

Copy link
Copy Markdown
Member Author

@github-actions crossbow submit test-conda-python-3.11-hypothesis

@github-actions

Copy link
Copy Markdown

Revision: a3230ba

Submitted crossbow builds: ursacomputing/crossbow @ actions-b602cce81d

Task Status
test-conda-python-3.11-hypothesis Github Actions

@raulcd raulcd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@raulcd raulcd merged commit 8fb4bf5 into apache:main Jun 30, 2023
@raulcd raulcd removed the awaiting committer review Awaiting committer review label Jun 30, 2023
@github-actions github-actions Bot added the awaiting merge Awaiting merge label Jun 30, 2023
@jorisvandenbossche jorisvandenbossche deleted the gh-36349-hypothesis-localtime branch June 30, 2023 10:39
@conbench-apache-arrow

Copy link
Copy Markdown

Conbench analyzed the 6 benchmark runs on commit 8fb4bf5e.

There were 2 benchmark results indicating a performance regression:

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Python][CI] Hypothesis nightly test fails with pytz.exceptions.UnknownTimeZoneError: 'build/etc/localtime'

2 participants